Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support posix style argument for --user" #631

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Support posix style argument for --user" #631

merged 3 commits into from
Jul 27, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Jul 27, 2020

Signed-off-by: Lonng [email protected]

What problem does this PR solve?

Support posix style argument for --user"

$ tiup cluster deploy -uroot

@lonng lonng added the category/usability Categorizes issue or PR as a usability enhancement. label Jul 27, 2020
@lonng lonng added this to the v1.1.0 milestone Jul 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #631 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #631   +/-   ##
=======================================
  Coverage   47.97%   47.97%           
=======================================
  Files         225      225           
  Lines       16787    16787           
=======================================
  Hits         8053     8053           
  Misses       7609     7609           
  Partials     1125     1125           
Flag Coverage Δ
#coverage 47.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3baffa1...67f584d. Read the comment docs.

lonng added 3 commits July 27, 2020 13:57
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2020
@lonng lonng merged commit 4ce9c65 into master Jul 27, 2020
@lonng lonng deleted the deploy-user branch July 27, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants