Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support refresh configuration only when reload #625

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Jul 23, 2020

Signed-off-by: Lonng [email protected]

What problem does this PR solve?

Support refresh configuration only when reload

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Related changes

  • Need to update the documentation

@lonng lonng added the type/new-feature Categorizes pr as related to a new feature. label Jul 23, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #625 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #625   +/-   ##
=======================================
  Coverage   47.85%   47.85%           
=======================================
  Files         225      225           
  Lines       16747    16749    +2     
=======================================
+ Hits         8014     8016    +2     
  Misses       7608     7608           
  Partials     1125     1125           
Flag Coverage Δ
#coverage 47.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/github.com/pingcap/tiup/pkg/cluster/api/pdapi.go 52.17% <0.00%> (-1.25%) ⬇️
.../pingcap/tiup/components/cluster/command/reload.go 61.70% <0.00%> (+0.83%) ⬆️
.../pingcap/tiup/components/playground/utils/utils.go 31.91% <0.00%> (+4.25%) ⬆️
...c/github.com/pingcap/tiup/pkg/utils/http_client.go 76.19% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec224a...ec11a99. Read the comment docs.

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2020
@lonng lonng merged commit f00092f into master Jul 24, 2020
@lonng lonng deleted the skip-restart branch July 24, 2020 06:14
@lonng lonng modified the milestones: v1.1.0, v1.2.0 Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants