Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display grafana with grafana patched #2483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WalterWj
Copy link
Contributor

What problem does this PR solve?

After I patched grafana, the tiup cluster display does not display grafana url information, which causes users to feel confused and think that there is an unknown problem with the patch

What is changed and how it works?

grafana (patched) judgment added

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

./bin/tiup-cluster display tidb-xx
Cluster type:       tidb
Cluster name:       tidb-xx
Cluster version:    v7.1.5
Deploy user:        tidb
SSH type:           builtin
Dashboard URL:      http://172.16.xxx.xx:2399/dashboard
Dashboard URLs:     http://172.16.xxx.xx:2399/dashboard
Grafana URL:        http://172.16.xxx.xx:3100
ID                   Role               Host           Ports                            OS/Arch       Status   Data Dir                                 Deploy Dir
--                   ----               ----           -----                            -------       ------   --------                                 ----------
172.16.xxx.xx:9193   alertmanager       172.16.xxx.xx  9193/9194                        linux/x86_64  Up       /data2/tiup/tidb-data/alertmanager-9193  /data2/tiup/tidb-deploy/alertmanager-9193
172.16.xxx.xx:8300   cdc                172.16.xxx.xx  8300                             linux/x86_64  Up       /data2/tiup/tidb-data/cdc-8300           /data2/tiup/tidb-deploy/cdc-8300
172.16.xxx.xx:3100   grafana (patched)  172.16.xxx.xx  3100                             linux/x86_64  Up       -                                        /data2/tiup/tidb-deploy/grafana-3100
172.16.xxx.xx:2399   pd                 172.16.xxx.xx  2399/2400                        linux/x86_64  Up|L|UI  /data2/tiup/tidb-data/pd-2399            /data2/tiup/tidb-deploy/pd-2399
172.16.xxx.xx:9103   prometheus         172.16.xxx.xx  9103/12020                       linux/x86_64  Up       /data2/tiup/tidb-data/prometheus-9103    /data2/tiup/tidb-deploy/prometheus-9103
172.16.xxx.xx:4100   tidb               172.16.xxx.xx  4100/10180                       linux/x86_64  Up       -                                        /data2/tiup/tidb-deploy/tidb-4100
172.16.xxx.xx:9000   tiflash            172.16.xxx.xx  9000/3930/20170/20292/8234/8123  linux/x86_64  Up       /data2/tiup/tidb-data/tiflash-9000       /data2/tiup/tidb-deploy/tiflash-9000
172.16.xxx.xx:21160  tikv               172.16.xxx.xx  21160/21180                      linux/x86_64  Up       /data2/tiup/tidb-data/tikv-21160         /data2/tiup/tidb-deploy/tikv-21160
Total nodes: 8

@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack December 16, 2024 06:50
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.36%. Comparing base (c39bd6e) to head (eb17dcd).

Current head eb17dcd differs from pull request most recent head ec0a1d5

Please upload reports for the commit ec0a1d5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
- Coverage   50.77%   46.36%   -4.41%     
==========================================
  Files         335      335              
  Lines       36383    36383              
==========================================
- Hits        18472    16867    -1605     
- Misses      15665    17462    +1797     
+ Partials     2246     2054     -192     
Flag Coverage Δ
cluster 32.50% <100.00%> (-9.20%) ⬇️
dm 19.10% <0.00%> (-6.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-16 08:45:20.670275566 +0000 UTC m=+860110.759078104: ☑️ agreed by breezewish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants