Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: Update supported OS versions #2476

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 13, 2024

What problem does this PR solve?

tiup cluster check ... might report different information than https://docs.pingcap.com/tidb/stable/hardware-and-software-requirements#os-and-platform-requirements

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from breezewish November 13, 2024 09:27
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack November 13, 2024 09:27
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2024
@dveeden dveeden force-pushed the os_version_check_nov_2024 branch from 6a16c5e to 21ec16b Compare November 13, 2024 09:27
case "centos":
// CentOS Linux is EOL
// CentOS Stream 9 and newer is still fine
if ver, _ := strconv.ParseFloat(osInfo.Version, 64); ver < 9 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a little newer to me, maybe 7.3 or so? Or mark result.warn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You think we should still list CentOS Linux 7.3 as supported?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You think we should still list CentOS Linux 7.3 as supported?

I just worry existed tiup deployed on CentOS7 will error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CentOS Linux 7.3 and CentOS Stream 8 don't have upstream support anymore as they are EOL.

TiDB will end support for CentOS 7 in v8.5.

This is just a check and it won't prevent deployment.

I'm ok with listing 7.x as supported for now and then add a warning about deprecation.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-16 05:30:27.961807903 +0000 UTC m=+679790.152676892: ☑️ agreed by xhebox.

@xhebox xhebox merged commit f7d5cb8 into pingcap:master Nov 16, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants