-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include MySQL 9.x in versions that don't need --comments #2469
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2469 +/- ##
==========================================
+ Coverage 54.97% 54.98% +0.01%
==========================================
Files 336 335 -1
Lines 36390 36383 -7
==========================================
+ Hits 20004 20005 +1
+ Misses 13971 13962 -9
- Partials 2415 2416 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
What problem does this PR solve?
The
--comments
option inmysql
is only needed in versions older than 8.1 as it has become the default. This works for MySQL Client 8.1, 8.4, etc, but not for MySQL 9. This PR fixes that.What is changed and how it works?
Check List
Tests
Release notes: