Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MySQL 9.x in versions that don't need --comments #2469

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 1, 2024

What problem does this PR solve?

The --comments option in mysql is only needed in versions older than 8.1 as it has become the default. This works for MySQL Client 8.1, 8.4, etc, but not for MySQL 9. This PR fixes that.

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

The `--comments` option is not needed for MySQL Client 9.x, it is now hidden

Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from breezewish and kaaaaaaang November 1, 2024 07:51
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 1, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 10, 2024
@dveeden dveeden requested a review from breezewish December 10, 2024 07:22
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-01 09:45:34.347993383 +0000 UTC m=+602247.187148924: ☑️ agreed by breezewish.
  • 2024-12-10 07:22:07.606372227 +0000 UTC m=+336717.695174771: ✖️🔁 reset by dveeden.
  • 2024-12-10 07:26:07.220418001 +0000 UTC m=+336957.309220541: ☑️ agreed by breezewish.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.98%. Comparing base (f7d5cb8) to head (97a9a94).
Report is 1 commits behind head on master.

Current head 97a9a94 differs from pull request most recent head 4df5729

Please upload reports for the commit 4df5729 to get more accurate results.

Files with missing lines Patch % Lines
components/playground/playground.go 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2469      +/-   ##
==========================================
+ Coverage   54.97%   54.98%   +0.01%     
==========================================
  Files         336      335       -1     
  Lines       36390    36383       -7     
==========================================
+ Hits        20004    20005       +1     
+ Misses      13971    13962       -9     
- Partials     2415     2416       +1     
Flag Coverage Δ
playground 26.38% <20.00%> (+10.23%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang kaaaaaaang requested a review from xhebox December 10, 2024 08:07
@xhebox xhebox merged commit c39bd6e into pingcap:master Dec 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants