Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix # cannot be included in grafana password #2468

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

kaaaaaaang
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack October 31, 2024 18:03
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 4, 2024
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 08:32:06.881740623 +0000 UTC m=+857039.720896169: ☑️ agreed by xhebox.
  • 2024-11-08 02:12:25.660790705 +0000 UTC m=+1179858.499946250: ✖️🔁 reset by xhebox.
  • 2024-11-08 03:08:22.349574739 +0000 UTC m=+1183215.188730285: ☑️ agreed by xhebox.

@xhebox xhebox merged commit 235c85e into master Nov 8, 2024
19 of 20 checks passed
@xhebox xhebox deleted the fix-grafana-pwd branch November 8, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants