Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix that scaled nodes don't respect component_versions #2451

Merged
merged 18 commits into from
Aug 16, 2024

Conversation

djshow832
Copy link
Contributor

@djshow832 djshow832 commented Aug 13, 2024

What problem does this PR solve?

close #2450

When scale-out a component, the version of the scaled node doesn't respect the version specified in the component_versions of the original spec.

What is changed and how it works?

When creating the new topology, copy ComponentVersions to newPart, which is used when deploying new instances. Tests show that the component_versions would be merged correctly when parsing the scale-out topology.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Follow the steps in the issue and check the version of the scale node.

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

- Fix that scaled nodes don't respect `component_versions`

@ti-chi-bot ti-chi-bot bot requested a review from breezewish August 13, 2024 09:26
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 13, 2024
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.11%. Comparing base (ac3a39e) to head (21f5bb4).
Report is 2 commits behind head on master.

Current head 21f5bb4 differs from pull request most recent head cd90a92

Please upload reports for the commit cd90a92 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (ac3a39e) and HEAD (21f5bb4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ac3a39e) HEAD (21f5bb4)
unittest 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
- Coverage   55.19%   48.11%   -7.08%     
==========================================
  Files         334      333       -1     
  Lines       35981    36049      +68     
==========================================
- Hits        19859    17343    -2516     
- Misses      13742    16381    +2639     
+ Partials     2380     2325      -55     
Flag Coverage Δ
cluster 42.02% <100.00%> (-2.55%) ⬇️
dm 25.19% <0.00%> (+0.18%) ⬆️
playground 16.16% <0.00%> (+0.10%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xhebox and others added 6 commits August 13, 2024 20:39
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-13 10:54:15.727570214 +0000 UTC m=+265340.431039855: ☑️ agreed by xhebox.
  • 2024-08-13 11:54:53.634980719 +0000 UTC m=+268978.338450378: ✖️🔁 reset by xhebox.
  • 2024-08-16 07:21:39.758975131 +0000 UTC m=+511784.462444778: ☑️ agreed by xhebox.

@xhebox xhebox merged commit 853c6a2 into pingcap:master Aug 16, 2024
19 of 20 checks passed
@djshow832 djshow832 deleted the scale_version branch August 16, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaled component version doesn't respect component_versions in the original spec
3 participants