Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdms(playground, cluster): add name to start pdms #2447

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Jul 31, 2024

What problem does this PR solve?

What is changed and how it works?

after tikv/pd#8461, we can start PDms with name.
But startup previous pd which support ms before 8.3.0 will failure because of unkown flag
img_v3_02cm_72c1d9cf-37ae-4b94-9399-ea4c42e450eg

for 8.2.0

$ cat tidb-deploy/tso-3379/scripts/run_tso.sh
#!/bin/bash
set -e

# WARNING: This file was auto-generated. Do not edit!
#          All your edit might be overwritten!
DEPLOY_DIR=/root/husharp/tidb-deploy/tso-3379

cd "${DEPLOY_DIR}" || exit 1
exec env GODEBUG=madvdontneed=1 bin/pd-server services tso \
    --backend-endpoints="http://10.2.7.79:2379" \
    --listen-addr="http://10.2.7.79:3379" \
    --advertise-listen-addr="http://10.2.7.79:3379" \
    --config=conf/tso.toml \
    --log-file="/root/husharp/tidb-deploy/tso-3379/log/tso.log" 2>> "/root/husharp/tidb-deploy/tso-3379/log/tso_stderr.log"

after ./tiup-cluster upgrade tidb-test v8.2.0 --tso-version v8.3.0 and with

tso_servers:
  - host:  10.2.7.79
    port: 3379
    name: "tso-0"

we can cat tidb-deploy/tso-3379/scripts

$ cat tidb-deploy/tso-3379/scripts/run_tso.sh
#!/bin/bash
set -e

# WARNING: This file was auto-generated. Do not edit!
#          All your edit might be overwritten!
DEPLOY_DIR=/root/husharp/tidb-deploy/tso-3379

cd "${DEPLOY_DIR}" || exit 1
exec env GODEBUG=madvdontneed=1 bin/pd-server services tso \
    --name="tso-0" \
    --backend-endpoints="http://10.2.7.79:2379" \
    --listen-addr="http://10.2.7.79:3379" \
    --advertise-listen-addr="http://10.2.7.79:3379" \
    --config=conf/tso.toml \
    --log-file="/root/husharp/tidb-deploy/tso-3379/log/tso.log" 2>> "/root/husharp/tidb-deploy/tso-3379/log/tso_stderr.log"

We need to keep compatible by changing pdms script

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack July 31, 2024 03:42
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 31, 2024
@kaaaaaaang kaaaaaaang changed the title pdms(playground, cluster): add name to start pdms [DNM]pdms(playground, cluster): add name to start pdms Jul 31, 2024
@HuSharp HuSharp changed the title [DNM]pdms(playground, cluster): add name to start pdms pdms(playground, cluster): add name to start pdms Aug 6, 2024
Copy link
Collaborator

@kaaaaaaang kaaaaaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-06 06:43:21.662823999 +0000 UTC m=+334331.529923088: ☑️ agreed by kaaaaaaang.

@kaaaaaaang kaaaaaaang requested a review from xhebox August 6, 2024 06:43
@xhebox
Copy link
Collaborator

xhebox commented Aug 7, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 7, 2024
@xhebox xhebox merged commit 9c22e67 into pingcap:master Aug 7, 2024
17 of 20 checks passed
@HuSharp HuSharp deleted the add_name_to_pdms2 branch August 7, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants