Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: do not need to check TiFlash http_port #2440

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from nexustar July 15, 2024 06:57
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack July 15, 2024 06:57
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2024
@Lloyd-Pottiger Lloyd-Pottiger changed the title Cluster: do not need to check TiFlash Http port Cluster: do not need to check TiFlash http_port Jul 15, 2024
@Lloyd-Pottiger Lloyd-Pottiger changed the title Cluster: do not need to check TiFlash http_port cluster: do not need to check TiFlash http_port Jul 15, 2024
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @breezewish @JaySon-Huang

@ti-chi-bot ti-chi-bot bot requested a review from breezewish July 19, 2024 06:25
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

@Lloyd-Pottiger: GitHub didn't allow me to request PR reviews from the following users: JaySon-Huang.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @breezewish @JaySon-Huang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-19 07:24:55.591226202 +0000 UTC m=+597917.582167672: ☑️ agreed by breezewish.

Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Lloyd-Pottiger
Copy link
Contributor Author

/assign @xhebox

@xhebox xhebox merged commit c3b91fe into pingcap:master Jul 23, 2024
19 of 20 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-check-tiflash-http-port branch July 23, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants