Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup & playground: Tidy output #2335

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Dec 19, 2023

What problem does this PR solve?

Make output more cleaner for tiup and playground.

What is changed and how it works?

Before:
image

After:
image
image

Also introduced a new utility colorstr, which can be used to print colors easier.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

Signed-off-by: Wish <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from nexustar December 19, 2023 08:02
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (ced2d6d) 47.65% compared to head (0f1239d) 49.17%.

❗ Current head 0f1239d differs from pull request most recent head 2885ac4. Consider uploading reports for the commit 2885ac4 to get more accurate results

Files Patch % Lines
pkg/exec/run.go 7.69% 36 Missing ⚠️
components/playground/main.go 0.00% 11 Missing ⚠️
pkg/tui/colorstr/color.go 69.23% 8 Missing ⚠️
pkg/tui/colorstr/test_util.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2335      +/-   ##
==========================================
+ Coverage   47.65%   49.17%   +1.51%     
==========================================
  Files         307      327      +20     
  Lines       33819    34812     +993     
==========================================
+ Hits        16116    17116    +1000     
+ Misses      15715    15447     -268     
- Partials     1988     2249     +261     
Flag Coverage Δ
cluster 43.19% <ø> (+1.25%) ⬆️
dm 25.44% <ø> (?)
playground 15.31% <23.26%> (?)
tiup 33.56% <36.00%> (+0.08%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Wish <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2023
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 19, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-19 09:42:20.017326468 +0000 UTC m=+954031.054553397: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot merged commit 93560a1 into pingcap:master Dec 19, 2023
19 checks passed
@breezewish breezewish deleted the wenxuan/tidy-stdout branch December 19, 2023 13:46
@kaaaaaaang kaaaaaaang modified the milestones: v1.14.1, v1.15.0 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants