Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use port to probe db in playground #2296

Conversation

KanShiori
Copy link
Collaborator

@KanShiori KanShiori commented Oct 31, 2023

What problem does this PR solve?

Close #2221

What is changed and how it works?

Use port not root user to probe db in playground.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Create a tidb configuration that contains init SQL to init root password.

    # init.sql
    ALTER USER 'root'@'%' IDENTIFIED BY '123';
    
    # tidb.toml
    initialize-sql-file = "/root/shiori/pingcap/tiup/bin/init.sql"
  2. Execute tiup playground --db.config tidb.toml.
    image

  3. Connect db with password successfully.
    image

  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdf6f26) 55.54% compared to head (2aa3450) 55.53%.

❗ Current head 2aa3450 differs from pull request most recent head a43b536. Consider uploading reports for the commit a43b536 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
- Coverage   55.54%   55.53%   -0.01%     
==========================================
  Files         326      326              
  Lines       34421    34413       -8     
==========================================
- Hits        19117    19109       -8     
  Misses      13022    13022              
  Partials     2282     2282              
Flag Coverage Δ
playground 15.47% <100.00%> (-0.05%) ⬇️
tiup 15.68% <ø> (ø)
unittest 22.47% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
components/playground/main.go 59.37% <100.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 31, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 31, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Oct 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 06:15:35.33369352 +0000 UTC m=+2933732.920803668: ☑️ agreed by kaaaaaaang.
  • 2023-10-31 06:17:26.298401217 +0000 UTC m=+2933843.885511344: ✖️🔁 reset by KanShiori.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2023

New changes are detected. LGTM label has been removed.

@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Oct 31, 2023
@KanShiori KanShiori merged commit b8fbc84 into pingcap:master Oct 31, 2023
4 checks passed
@KanShiori KanShiori deleted the shiori/connect-without-password-in-playground branch October 31, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiup playground use root user check tidb status may cause problem.
3 participants