Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tidbver.TiDBSupportUpgradeAPI #2289

Merged
merged 2 commits into from
Oct 17, 2023
Merged

update tidbver.TiDBSupportUpgradeAPI #2289

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cda0829
update tidbver.TiDBSupportUpgradeAPI
kaaaaaaang Oct 17, 2023
8626df3
fix
kaaaaaaang Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/tidbver/tidbver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ func TiDBSupportSecureBoot(version string) bool {

// TiDBSupportUpgradeAPI return if given version of TiDB support upgrade API
func TiDBSupportUpgradeAPI(version string) bool {
return semver.Compare(version, "v7.4.0") >= 0 || strings.Contains(version, "nightly")
return semver.Compare(version, "v7.4.0") >= 0 ||
(semver.MajorMinor(version) == "v7.1" && semver.Compare(version, "v7.1.2") >= 0) ||
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, probably not.
For example, upgrade from v7.1.2 to v7.4. However v7.4 does not support the upgrade function.

strings.Contains(version, "nightly")
}

// TiKVSupportAdvertiseStatusAddr return if given version of TiKV support --advertise-status-addr
Expand Down
Loading