Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade to go1.19 #2033

Merged
merged 4 commits into from
Sep 16, 2022
Merged

*: upgrade to go1.19 #2033

merged 4 commits into from
Sep 16, 2022

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Update to fit go1.19.

Close #1976

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@AstroProfundis AstroProfundis self-assigned this Sep 2, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Base: 47.59% // Head: 48.15% // Increases project coverage by +0.55% 🎉

Coverage data is based on head (b5b4bb3) compared to base (d6a2826).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head b5b4bb3 differs from pull request most recent head f8c9810. Consider uploading reports for the commit f8c9810 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
+ Coverage   47.59%   48.15%   +0.55%     
==========================================
  Files         312      308       -4     
  Lines       36379    35946     -433     
==========================================
- Hits        17314    17307       -7     
+ Misses      17027    16587     -440     
- Partials     2038     2052      +14     
Flag Coverage Δ
cluster 35.16% <0.00%> (+1.86%) ⬆️
dm 23.78% <0.00%> (-0.05%) ⬇️
playground 12.94% <0.00%> (-0.06%) ⬇️
tiup 14.25% <0.00%> (+0.24%) ⬆️
unittest 20.80% <0.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/audit.go 41.38% <ø> (ø)
pkg/cluster/executor/checkpoint.go 77.36% <ø> (ø)
pkg/cluster/spec/server_config.go 71.62% <ø> (+0.90%) ⬆️
pkg/cluster/task/update_topology.go 74.07% <ø> (ø)
pkg/repository/store/txn.go 56.91% <ø> (ø)
pkg/tidbver/tidbver.go 94.74% <ø> (-0.39%) ⬇️
pkg/tui/progress/renderer.go 79.49% <0.00%> (ø)
pkg/cluster/executor/ssh.go 36.63% <0.00%> (-25.64%) ⬇️
pkg/cluster/executor/executor.go 56.38% <0.00%> (-7.45%) ⬇️
pkg/cluster/spec/pump.go 60.00% <0.00%> (-4.52%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b5b4bb3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2022
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0be11e9 into pingcap:master Sep 16, 2022
@AstroProfundis AstroProfundis deleted the go1.19 branch September 16, 2022 05:35
@nexustar nexustar added this to the v1.11.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants