-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc rolling upgrade / scale-in ultilize two-phase-scheduling #1972
cdc rolling upgrade / scale-in ultilize two-phase-scheduling #1972
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
My development Golang version is |
Codecov Report
@@ Coverage Diff @@
## master #1972 +/- ##
===========================================
- Coverage 52.54% 39.98% -12.55%
===========================================
Files 307 291 -16
Lines 35485 34940 -545
===========================================
- Hits 18643 13970 -4673
- Misses 14648 19369 +4721
+ Partials 2194 1601 -593
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@3AceShowHand: GitHub didn't allow me to request PR reviews from the following users: overvenus. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…howHand/tiup into cdc-scale-in-drain-capture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not familiar with TiCDC openapi, rest LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 05ccc02
|
What problem does this PR solve?
try close #1971
What is changed and how it works?
When rolling upgrade or scale in TiCDC instance, call
DrainCapture
to move all tables replicating on it to other running instance.RollingUpgradeInstance
interface for the TiCDC.upgrade
/patch
/scale-in
/reload
will use the feature.Check List
Tests
Code changes
Side effects
Related changes
Release notes: