Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: fix peer-urls of dm-master #1926

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #1926 (c067a76) into master (568324c) will increase coverage by 28.42%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1926       +/-   ##
===========================================
+ Coverage   23.95%   52.37%   +28.42%     
===========================================
  Files         281      307       +26     
  Lines       32522    35462     +2940     
===========================================
+ Hits         7788    18572    +10784     
+ Misses      23864    14695     -9169     
- Partials      870     2195     +1325     
Flag Coverage Δ
cluster 40.92% <ø> (?)
dm 24.40% <ø> (?)
playground 12.94% <ø> (?)
tiup 14.45% <ø> (ø)
unittest 21.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/destroy.go 59.45% <0.00%> (ø)
components/dm/task/update_dm_meta.go 87.76% <0.00%> (ø)
components/playground/instance/process.go 92.31% <0.00%> (ø)
pkg/cluster/operation/check.go 47.42% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 55.13% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 80.00% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
pkg/cluster/operation/pd_member.go 0.00% <0.00%> (ø)
pkg/logger/debug.go 16.67% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 55.88% <0.00%> (ø)
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568324c...c067a76. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2022
@srstack
Copy link
Collaborator

srstack commented Jun 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 967ebdb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2022
@ti-chi-bot
Copy link
Member

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nexustar
Copy link
Collaborator Author

/merge

@AstroProfundis AstroProfundis added this to the v1.10.2 milestone Jun 16, 2022
@ti-chi-bot ti-chi-bot merged commit 1103596 into pingcap:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM cluster can't start while -hostname use FQDN
5 participants