Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion: show cluster list when click tab #1891

Merged
merged 4 commits into from
May 25, 2022

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #1891 (8bcd891) into master (7ad779c) will decrease coverage by 2.73%.
The diff coverage is 2.16%.

❗ Current head 8bcd891 differs from pull request most recent head 2723be5. Consider uploading reports for the commit 2723be5 to get more accurate results

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   47.77%   45.04%   -2.73%     
==========================================
  Files         307      307              
  Lines       35161    35373     +212     
==========================================
- Hits        16795    15931     -864     
- Misses      16380    17537    +1157     
+ Partials     1986     1905      -81     
Flag Coverage Δ
cluster 28.81% <3.79%> (-4.22%) ⬇️
dm 24.45% <4.17%> (-0.08%) ⬇️
tiup 14.35% <0.00%> (ø)
unittest 21.05% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/clean.go 55.10% <0.00%> (-7.69%) ⬇️
components/cluster/command/deploy.go 58.33% <0.00%> (-6.48%) ⬇️
components/cluster/command/destroy.go 60.53% <0.00%> (-11.35%) ⬇️
components/cluster/command/disable.go 30.77% <0.00%> (-9.23%) ⬇️
components/cluster/command/display.go 43.48% <0.00%> (-11.07%) ⬇️
components/cluster/command/edit_config.go 34.78% <0.00%> (-12.28%) ⬇️
components/cluster/command/enable.go 30.77% <0.00%> (-9.23%) ⬇️
components/cluster/command/exec.go 66.67% <0.00%> (-19.05%) ⬇️
components/cluster/command/prune.go 59.09% <0.00%> (-22.16%) ⬇️
components/cluster/command/reload.go 35.71% <0.00%> (-22.62%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad779c...2723be5. Read the comment docs.

@nexustar nexustar closed this May 24, 2022
@nexustar nexustar reopened this May 24, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2022
@nexustar nexustar added this to the v1.10.0 milestone May 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 387c964

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2022
@ti-chi-bot ti-chi-bot merged commit 47d9f8b into pingcap:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants