Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update tidb version #1847

Merged
merged 15 commits into from
May 12, 2022
Merged

test: update tidb version #1847

merged 15 commits into from
May 12, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Apr 18, 2022

What problem does this PR solve?

What is changed and how it works?

  • update tidb version in test to v6.0.0
  • increase wait time for kill playgorund

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #1847 (320f1f9) into master (4f8a44a) will increase coverage by 26.04%.
The diff coverage is n/a.

❗ Current head 320f1f9 differs from pull request most recent head 8372055. Consider uploading reports for the commit 8372055 to get more accurate results

@@             Coverage Diff             @@
##           master    #1847       +/-   ##
===========================================
+ Coverage   24.13%   50.17%   +26.04%     
===========================================
  Files         281      305       +24     
  Lines       32263    35084     +2821     
===========================================
+ Hits         7786    17602     +9816     
+ Misses      23606    15379     -8227     
- Partials      871     2103     +1232     
Flag Coverage Δ
cluster 41.18% <ø> (?)
playground 12.74% <ø> (?)
tiup 14.36% <ø> (+0.02%) ⬆️
unittest 21.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/command/deploy.go 42.55% <0.00%> (-1.63%) ⬇️
pkg/tidbver/tidbver.go
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
pkg/logger/debug.go 16.67% <0.00%> (ø)
components/playground/instance/tiflash.go 59.12% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/process.go 92.31% <0.00%> (ø)
pkg/cluster/operation/pd_member.go 0.00% <0.00%> (ø)
pkg/cluster/operation/download.go 33.33% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 54.12% <0.00%> (ø)
... and 189 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8a44a...8372055. Read the comment docs.

@AstroProfundis
Copy link
Contributor

is the test failing due to OOM?

@nexustar
Copy link
Collaborator Author

is the test failing due to OOM?

I tried run playground in a 4G-RAM vm, it works well :(

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2022
@nexustar
Copy link
Collaborator Author

nexustar commented May 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 50a7349

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2022
@ti-chi-bot
Copy link
Member

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2022
@nexustar nexustar closed this May 12, 2022
@nexustar nexustar reopened this May 12, 2022
@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8372055

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2022
@ti-chi-bot ti-chi-bot merged commit f062b88 into pingcap:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants