Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: fix wrong woakload loading #1827

Merged
merged 5 commits into from
May 27, 2022
Merged

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Apr 1, 2022

What problem does this PR solve?

readproportion must be set to 0 by default here, otherwise we can't load workload correctly

// these config are always included in the config file
// should be overwritten if they are passed through the command line
if config.ReadProportion != 0 {
// we don't need to check errors since we disabled expansion
_, _, _ = result.Set("readproportion", fmt.Sprint(config.ReadProportion))
}

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2022
@Smityz
Copy link
Contributor Author

Smityz commented Apr 1, 2022

@srstack Can you help me to check this PR?
I introduce this bug in #1807

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #1827 (0c5aa04) into master (762dd94) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0c5aa04 differs from pull request most recent head 755a280. Consider uploading reports for the commit 755a280 to get more accurate results

@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
- Coverage   52.61%   52.60%   -0.01%     
==========================================
  Files         306      306              
  Lines       34986    34986              
==========================================
- Hits        18405    18401       -4     
- Misses      14420    14423       +3     
- Partials     2161     2162       +1     
Flag Coverage Δ
playground 12.79% <ø> (ø)
tiup 14.44% <ø> (-0.02%) ⬇️
unittest 21.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762dd94...755a280. Read the comment docs.

@AstroProfundis AstroProfundis requested review from srstack and removed request for lucklove April 13, 2022 07:02
@srstack
Copy link
Collaborator

srstack commented Apr 18, 2022

why not modify here?

// these config are always included in the config file
// should be overwritten if they are passed through the command line
if config.ReadProportion != 0 {
// we don't need to check errors since we disabled expansion
_, _, _ = result.Set("readproportion", fmt.Sprint(config.ReadProportion))
}

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2022
@Smityz Smityz force-pushed the fix-default-value branch from 0c5aa04 to 755a280 Compare April 21, 2022 15:13
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2022
@AstroProfundis AstroProfundis added this to the v1.10.0 milestone May 27, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b073c3f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot ti-chi-bot merged commit 04c4927 into pingcap:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants