-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: fix wrong woakload loading #1827
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
- Coverage 52.61% 52.60% -0.01%
==========================================
Files 306 306
Lines 34986 34986
==========================================
- Hits 18405 18401 -4
- Misses 14420 14423 +3
- Partials 2161 2162 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
why not modify here? Lines 85 to 90 in 9060112
|
0c5aa04
to
755a280
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b073c3f
|
What problem does this PR solve?
readproportion
must be set to 0 by default here, otherwise we can't load workload correctlytiup/components/bench/ycsb.go
Lines 85 to 90 in 9060112
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: