Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: fix the typo in the error message of bench command #1824

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

Mini256
Copy link
Member

@Mini256 Mini256 commented Mar 30, 2022

What problem does this PR solve?

Fix the typo in the error message of bench command.

What is changed and how it works?

s/pleae/please/

Check List

Tests

  • Manual test (add detailed scripts or steps below)
make
./bin/tiup-bench tpcc run

Code changes

None

Side effects

None

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #1824 (a233bb3) into master (4166dfb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1824   +/-   ##
=======================================
  Coverage   53.00%   53.00%           
=======================================
  Files         303      303           
  Lines       34663    34663           
=======================================
  Hits        18372    18372           
  Misses      14142    14142           
  Partials     2149     2149           
Flag Coverage Δ
tiup 14.39% <ø> (ø)
unittest 21.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4166dfb...a233bb3. Read the comment docs.

@nexustar nexustar added this to the v1.9.4 milestone Mar 30, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a233bb3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2022
@ti-chi-bot ti-chi-bot merged commit 514d2ae into pingcap:master Mar 30, 2022
@Mini256 Mini256 deleted the fix-typo branch March 30, 2022 10:43
@AstroProfundis AstroProfundis modified the milestones: v1.9.4, v1.10.0 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants