Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/dm: support backup and restore cluster meta #1801

Merged
merged 10 commits into from
Apr 15, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Mar 18, 2022

What problem does this PR solve?

What is changed and how it works?

Screenshot from 2022-03-18 15-39-19

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis
  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2022
@nexustar nexustar requested review from srstack and qqqdan and removed request for lucklove March 18, 2022 07:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #1801 (ff0b588) into master (d6ab2cc) will decrease coverage by 5.32%.
The diff coverage is 24.28%.

@@            Coverage Diff             @@
##           master    #1801      +/-   ##
==========================================
- Coverage   52.94%   47.62%   -5.32%     
==========================================
  Files         303      304       +1     
  Lines       34695    34857     +162     
==========================================
- Hits        18366    16599    -1767     
- Misses      14175    16107    +1932     
+ Partials     2154     2151       -3     
Flag Coverage Δ
cluster 41.04% <15.56%> (-0.16%) ⬇️
dm 24.71% <15.56%> (+<0.01%) ⬆️
tiup 14.35% <0.00%> (-0.02%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/basic.go 41.09% <0.00%> (-13.50%) ⬇️
pkg/utils/ioutil.go 48.64% <0.00%> (-11.45%) ⬇️
components/cluster/command/meta.go 54.05% <54.05%> (ø)
components/dm/command/meta.go 54.05% <54.05%> (ø)
components/cluster/command/root.go 46.02% <100.00%> (+0.19%) ⬆️
components/dm/command/root.go 56.50% <100.00%> (+0.22%) ⬆️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/crypto/rand/passwd.go 0.00% <0.00%> (-75.00%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ab2cc...ff0b588. Read the comment docs.

components/dm/command/meta.go Outdated Show resolved Hide resolved
components/dm/command/meta.go Outdated Show resolved Hide resolved
components/dm/command/meta.go Outdated Show resolved Hide resolved
components/dm/command/meta.go Outdated Show resolved Hide resolved
pkg/cluster/manager/basic.go Outdated Show resolved Hide resolved
pkg/cluster/manager/basic.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@srstack srstack self-requested a review March 22, 2022 07:52
@srstack srstack removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
@AstroProfundis AstroProfundis added this to the v1.10.0 milestone Mar 28, 2022
@nexustar nexustar requested a review from AstroProfundis April 13, 2022 09:38
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ff0b588

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@ti-chi-bot ti-chi-bot merged commit 0c90f84 into pingcap:master Apr 15, 2022
@dveeden
Copy link
Contributor

dveeden commented Jun 17, 2022

I didn't see any docs updates for this yet. Is there something I can help to review?

cc @TomShawn @qiancai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support backup meta.yaml
6 participants