Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grafana embedding config #1785

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Conversation

sunzhaoyang
Copy link
Contributor

@sunzhaoyang sunzhaoyang commented Mar 9, 2022

What problem does this PR solve?

There is no need for repeated development work, it can be directly embedded grafana in WebUI to view Cluster statistics.

So it's need to make grafana allow anonymous access.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2022

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from july2993 and lonng March 9, 2022 07:05
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #1785 (7b9aca8) into master (22d412f) will decrease coverage by 3.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1785      +/-   ##
==========================================
- Coverage   52.82%   48.98%   -3.84%     
==========================================
  Files         303      303              
  Lines       34838    34641     -197     
==========================================
- Hits        18400    16966    -1434     
- Misses      14283    15678    +1395     
+ Partials     2155     1997     -158     
Flag Coverage Δ
cluster 35.27% <ø> (-6.12%) ⬇️
dm 24.83% <ø> (-0.04%) ⬇️
playground 12.63% <ø> (+0.02%) ⬆️
tiup 14.40% <ø> (ø)
unittest 21.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/cluster/manager/check.go 5.28% <0.00%> (-63.03%) ⬇️
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-59.13%) ⬇️
pkg/cluster/task/copy_file.go 0.00% <0.00%> (-52.94%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-48.44%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-46.67%) ⬇️
pkg/cluster/manager/patch.go 0.00% <0.00%> (-42.68%) ⬇️
components/cluster/command/rename.go 27.78% <0.00%> (-38.89%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d412f...7b9aca8. Read the comment docs.

@sunzhaoyang
Copy link
Contributor Author

/cc @ljun0712

@ti-chi-bot
Copy link
Member

@sunzhaoyang: GitHub didn't allow me to request PR reviews from the following users: ljun0712.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ljun0712

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ljun0712
Copy link

From a security point of view, do not use anonymous login to access the monitoring data of the cluster. Monitoring data is very important, and access to it requires permission management and logging.
A more secure way can be considered: provide username/password

@sunzhaoyang
Copy link
Contributor Author

From a security point of view, do not use anonymous login to access the monitoring data of the cluster. Monitoring data is very important, and access to it requires permission management and logging. A more secure way can be considered: provide username/password

Maybe we can tell users the risk and disable by default. Users could make the choice depend on the situation.

Security and convenience most of the time do not go hand in hand, we should let the user choose.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@nexustar nexustar added this to the v1.9.3 milestone Mar 22, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 573d43f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022
@ti-chi-bot
Copy link
Member

@sunzhaoyang: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 62dc752 into pingcap:master Mar 22, 2022
AstroProfundis pushed a commit that referenced this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants