-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add grafana embedding config #1785
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1785 +/- ##
==========================================
- Coverage 52.82% 48.98% -3.84%
==========================================
Files 303 303
Lines 34838 34641 -197
==========================================
- Hits 18400 16966 -1434
- Misses 14283 15678 +1395
+ Partials 2155 1997 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/cc @ljun0712 |
@sunzhaoyang: GitHub didn't allow me to request PR reviews from the following users: ljun0712. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From a security point of view, do not use anonymous login to access the monitoring data of the cluster. Monitoring data is very important, and access to it requires permission management and logging. |
Maybe we can tell users the risk and disable by default. Users could make the choice depend on the situation. Security and convenience most of the time do not go hand in hand, we should let the user choose. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 573d43f
|
@sunzhaoyang: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
There is no need for repeated development work, it can be directly embedded grafana in WebUI to view Cluster statistics.
So it's need to make grafana allow anonymous access.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: