Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: completing the os type of the host #1753

Merged
merged 7 commits into from
Feb 15, 2022

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Feb 11, 2022

What problem does this PR solve?

Previously, the host would use the global os by default, but if it is a multi os mixed deployment, an exception will occur.

What is changed and how it works?

Completing the os type of the host like full cpu architecture

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #1753 (7efcf49) into master (f6f5c7b) will decrease coverage by 1.41%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
- Coverage   53.16%   51.74%   -1.41%     
==========================================
  Files         303      303              
  Lines       34401    34412      +11     
==========================================
- Hits        18287    17806     -481     
- Misses      13970    14504     +534     
+ Partials     2144     2102      -42     
Flag Coverage Δ
cluster 38.88% <71.08%> (-2.48%) ⬇️
dm 24.76% <70.24%> (-0.05%) ⬇️
playground 12.62% <0.00%> (-<0.01%) ⬇️
tiup 14.40% <0.00%> (-0.03%) ⬇️
unittest 21.32% <11.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/builder.go 71.24% <ø> (-0.70%) ⬇️
pkg/cluster/manager/check.go 68.31% <0.00%> (ø)
pkg/cluster/manager/deploy.go 68.60% <0.00%> (+1.16%) ⬆️
pkg/cluster/manager/scale_out.go 40.82% <0.00%> (-0.51%) ⬇️
pkg/cluster/manager/manager.go 72.89% <84.00%> (-1.11%) ⬇️
pkg/cluster/spec/spec.go 83.33% <84.21%> (+0.51%) ⬆️
components/cluster/command/check.go 75.56% <100.00%> (ø)
components/dm/spec/topology_dm.go 84.31% <100.00%> (-0.79%) ⬇️
pkg/cluster/ansible/inventory.go 57.78% <100.00%> (+0.78%) ⬆️
pkg/cluster/template/config/alertmanager.go 0.00% <0.00%> (-55.00%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f5c7b...7efcf49. Read the comment docs.

@nexustar
Copy link
Collaborator

Will we support multi os mixed deployment?

@srstack
Copy link
Collaborator Author

srstack commented Feb 14, 2022

Will we support multi os mixed deployment?
just for mac. :(

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2022
@AstroProfundis
Copy link
Contributor

We don't support mixed OS in the cluster (the on-going macOS support will only be released with local deployment), but it's fine to make the code compatible with that, as long as our integrate tests on Linux pass.

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7efcf49

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022
@ti-chi-bot ti-chi-bot merged commit 10da905 into pingcap:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants