-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: completing the os type of the host #1753
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
- Coverage 53.16% 51.74% -1.41%
==========================================
Files 303 303
Lines 34401 34412 +11
==========================================
- Hits 18287 17806 -481
- Misses 13970 14504 +534
+ Partials 2144 2102 -42
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Will we support multi os mixed deployment? |
|
We don't support mixed OS in the cluster (the on-going macOS support will only be released with local deployment), but it's fine to make the code compatible with that, as long as our integrate tests on Linux pass. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7efcf49
|
What problem does this PR solve?
Previously, the host would use the global os by default, but if it is a multi os mixed deployment, an exception will occur.
What is changed and how it works?
Completing the os type of the host like full cpu architecture
Check List
Tests
Release notes: