Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix wrong status when display due to closure #1742

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2022
@nexustar nexustar added this to the v1.9.0 milestone Jan 26, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #1742 (64e4021) into master (5a7693d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1742      +/-   ##
==========================================
- Coverage   53.16%   53.13%   -0.03%     
==========================================
  Files         303      303              
  Lines       34353    34357       +4     
==========================================
- Hits        18262    18253       -9     
- Misses      13945    13960      +15     
+ Partials     2146     2144       -2     
Flag Coverage Δ
cluster 41.35% <100.00%> (-0.05%) ⬇️
dm 24.78% <75.00%> (+0.05%) ⬆️
playground 12.73% <0.00%> (-<0.01%) ⬇️
tiup 14.52% <0.00%> (-<0.01%) ⬇️
unittest 21.41% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/alertmanager.go 67.39% <100.00%> (+0.36%) ⬆️
pkg/cluster/spec/grafana.go 63.81% <100.00%> (+0.17%) ⬆️
pkg/cluster/spec/monitoring.go 72.73% <100.00%> (+0.09%) ⬆️
pkg/cluster/spec/tispark.go 65.80% <100.00%> (+0.13%) ⬆️
pkg/utils/retry.go 46.43% <0.00%> (-16.07%) ⬇️
pkg/cluster/spec/tikv.go 61.31% <0.00%> (-1.31%) ⬇️
pkg/cluster/api/pdapi.go 58.94% <0.00%> (-0.53%) ⬇️
pkg/cluster/api/dmapi.go 61.63% <0.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7693d...64e4021. Read the comment docs.

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 64e4021

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@ti-chi-bot ti-chi-bot merged commit 44ceb86 into pingcap:master Jan 27, 2022
Copy link
Collaborator

@srstack srstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster: display down monitoring as up
5 participants