-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix json output for check results #1720
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
- Coverage 53.22% 47.17% -6.05%
==========================================
Files 303 302 -1
Lines 34270 34480 +210
==========================================
- Hits 18237 16263 -1974
- Misses 13886 16099 +2213
+ Partials 2147 2118 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2bd042e
|
What problem does this PR solve?
The output of
check
command intup-cluster
is a ASCII table, fix #1719What is changed and how it works?
Make it a JSON string when
--format=json
is setCheck List
Tests
Related changes
Release notes: