Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fix cannot find nightly version #1715

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #1715 (3bc7008) into master (f7a536b) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
- Coverage   53.29%   53.19%   -0.10%     
==========================================
  Files         303      303              
  Lines       34261    34267       +6     
==========================================
- Hits        18256    18226      -30     
- Misses      13864    13897      +33     
- Partials     2141     2144       +3     
Flag Coverage Δ
cluster 41.38% <0.00%> (-0.11%) ⬇️
dm 24.82% <0.00%> (-0.05%) ⬇️
playground 12.72% <0.00%> (-<0.01%) ⬇️
tiup 14.57% <0.00%> (-<0.01%) ⬇️
unittest 21.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/v1_repository.go 58.54% <0.00%> (-0.56%) ⬇️
pkg/utils/retry.go 46.43% <0.00%> (-16.07%) ⬇️
pkg/cluster/api/pdapi.go 58.94% <0.00%> (-2.12%) ⬇️
pkg/cluster/api/dmapi.go 59.88% <0.00%> (-1.74%) ⬇️
pkg/cluster/spec/tikv.go 61.31% <0.00%> (-1.31%) ⬇️
pkg/cluster/spec/tiflash.go 68.51% <0.00%> (-0.67%) ⬇️
pkg/cluster/task/update_meta.go 87.10% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a536b...3bc7008. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2022
@AstroProfundis
Copy link
Contributor

We should also add a note on the "starting component" outputs to let users know which version of the component is actually running (as they may not with strictly the same version anymore)

@AstroProfundis AstroProfundis added this to the v1.8.2 milestone Jan 10, 2022
@nexustar
Copy link
Collaborator Author

We should also add a note on the "starting component" outputs to let users know which version of the component is actually running (as they may not with strictly the same version anymore)

this fix is for v1.8.x, I will prepare another PR for that

@srstack srstack assigned srstack and nexustar and unassigned srstack Jan 10, 2022
Copy link
Collaborator

@srstack srstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3bc7008

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2022
@ti-chi-bot ti-chi-bot merged commit db793d8 into pingcap:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants