Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: support Chrony as NTP implementation #1714

Merged
merged 5 commits into from
Jan 12, 2022

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Jan 10, 2022

What problem does this PR solve?

close #1696

What is changed and how it works?

support Chrony as NTP implementation

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    image
  • just display the time offset for test
  • not display the time offse information if it < 500ms

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@srstack srstack self-assigned this Jan 10, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2022
@srstack
Copy link
Collaborator Author

srstack commented Jan 10, 2022

The new version of the insight tool has passed the test in 1.6.0 1.7.0 1.8.0.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #1714 (267d0f3) into master (5dc5a4a) will increase coverage by 0.00%.
The diff coverage is 27.27%.

❗ Current head 267d0f3 differs from pull request most recent head 8a777fa. Consider uploading reports for the commit 8a777fa to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1714   +/-   ##
=======================================
  Coverage   53.20%   53.20%           
=======================================
  Files         303      303           
  Lines       34301    34299    -2     
=======================================
- Hits        18248    18247    -1     
+ Misses      13909    13908    -1     
  Partials     2144     2144           
Flag Coverage Δ
cluster 41.41% <27.27%> (-0.04%) ⬇️
dm 24.79% <0.00%> (-0.03%) ⬇️
playground 12.72% <ø> (ø)
tiup 14.57% <ø> (ø)
unittest 21.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 49.00% <27.27%> (-1.97%) ⬇️
components/cluster/command/root.go 45.83% <0.00%> (+3.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc5a4a...8a777fa. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.9.0 milestone Jan 10, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8a777fa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2022
@srstack srstack removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
@ti-chi-bot ti-chi-bot merged commit 6fe71fe into pingcap:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster check also support Chrony as NTP implementation
4 participants