Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirror: Fix typos and naming #1705

Merged
merged 6 commits into from
Jan 6, 2022
Merged

mirror: Fix typos and naming #1705

merged 6 commits into from
Jan 6, 2022

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 4, 2022

What problem does this PR solve?

  • tiup mirrors doesn't exist, but tiup mirror does
  • Typo: mirros → mirrors
  • Typo: expirsAt → expiresAt

What is changed and how it works?

Check List

Tests

  • No code

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 4, 2022
@dveeden dveeden mentioned this pull request Jan 4, 2022
Closed
AstroProfundis
AstroProfundis reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@AstroProfundis AstroProfundis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR, we haven't updated the docs of mirror command for long time and many contents are not correct anymore.

doc/user/mirrors.md Outdated Show resolved Hide resolved
doc/user/mirrors.md Outdated Show resolved Hide resolved
@AstroProfundis AstroProfundis added this to the v1.8.2 milestone Jan 5, 2022
@dveeden @AstroProfundis
Update doc/user/mirrors.md
f467fbc 
Co-authored-by: Allen Zhong <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022 •
edited
Loading

Codecov Report

Merging #1705 (339e2e4) into master (e292245) will decrease coverage by 0.70%.
The diff coverage is 0.00%.

❗ Current head 339e2e4 differs from pull request most recent head 2f889f3. Consider uploading reports for the commit 2f889f3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   53.19%   52.49%   -0.70%     
==========================================
  Files         303      303              
  Lines       34479    34230     -249     
==========================================
- Hits        18341    17968     -373     
- Misses      13988    14106     +118     
- Partials     2150     2156       +6
Flag Coverage Δ
cluster 40.45% <0.00%> (-1.01%) ⬇️
dm 24.74% <0.00%> (+0.01%) ⬆️
playground 12.73% <0.00%> (-0.02%) ⬇️
tiup 14.59% <0.00%> (ø)
unittest 21.36% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/clone_mirror.go 0.00% <0.00%> (ø)
pkg/cluster/template/scripts/cdc.go 56.94% <0.00%> (-22.22%) ⬇️
pkg/utils/retry.go 46.43% <0.00%> (-16.07%) ⬇️
pkg/cluster/api/pdapi.go 47.96% <0.00%> (-11.50%) ⬇️
pkg/cluster/task/update_meta.go 76.34% <0.00%> (-10.75%) ⬇️
pkg/cluster/spec/cdc.go 66.32% <0.00%> (-10.53%) ⬇️
pkg/cluster/task/task.go 64.81% <0.00%> (-8.33%) ⬇️
pkg/tui/cliutil.go 63.95% <0.00%> (-6.98%) ⬇️
pkg/cluster/task/update_topology.go 61.73% <0.00%> (-6.17%) ⬇️
pkg/cluster/spec/util.go 73.21% <0.00%> (-5.36%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97056e...2f889f3. Read the comment docs.

@dveeden
Copy link
Contributor Author

dveeden commented Jan 5, 2022

@AstroProfundis PTAL

AstroProfundis
AstroProfundis reviewed Jan 6, 2022
View reviewed changes
doc/user/mirrors.md Outdated
Comment on lines 61 to 69
- Just want to clone amd64 architecture: `tiup mirror <target-dir> --arch=amd64`
- Just want to clone linux/amd64: `tiup mirror <target-dir> --os=linux --arch=amd64`

### 4. Component version limited

If you want to clone only one version of a component and not all versions, use `--<component>=<version>` to qualify, for example "
- Just want to clone the v4 version of tidb: `tiup mirrors <target-dir> --tidb v4`
- Just want to clone the v4 version of tidb, and all versions of tikv: `tiup mirros <target-dir> --tidb v4 --tikv all`
- Clone specific versions of all components that start a cluster: `tiup mirrors <target-dir> v4.0.0-rc`
- Just want to clone the v4 version of tidb: `tiup mirror <target-dir> --tidb v4`
- Just want to clone the v4 version of tidb, and all versions of tikv: `tiup mirror <target-dir> --tidb v4 --tikv all`
- Clone specific versions of all components that start a cluster: `tiup mirror <target-dir> v4.0.0-rc`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these examples should all be tiup mirror clone xxx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2f889f3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2022
@ti-chi-bot ti-chi-bot merged commit b98df00 into pingcap:master Jan 6, 2022
AstroProfundis pushed a commit that referenced this pull request Jan 10, 2022
@dveeden @AstroProfundis
mirror: Fix typos and naming (#1705)
399b6dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstroProfundis AstroProfundis AstroProfundis approved these changes

@july2993 july2993 Awaiting requested review from july2993

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
v1.8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@dveeden @ti-chi-bot @codecov-commenter @AstroProfundis