Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: nightly version could not be compared #1702

Merged
merged 10 commits into from
Jan 7, 2022

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Dec 31, 2021

What problem does this PR solve?

close pingcap/tiflow#4149

What is changed and how it works?

Get the complete nightly version number before initconfig operation

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release notes:

NONE

@srstack srstack self-assigned this Dec 31, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 31, 2021
@srstack
Copy link
Collaborator Author

srstack commented Dec 31, 2021

I'm not sure for the time being whether there is a comparison of nightly versions in other places.

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #1702 (c8bce36) into master (410c25c) will decrease coverage by 4.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1702      +/-   ##
==========================================
- Coverage   53.12%   48.64%   -4.49%     
==========================================
  Files         303      303              
  Lines       34245    34261      +16     
==========================================
- Hits        18192    16663    -1529     
- Misses      13907    15606    +1699     
+ Partials     2146     1992     -154     
Flag Coverage Δ
cluster 34.67% <52.94%> (-6.68%) ⬇️
dm 24.82% <100.00%> (+0.09%) ⬆️
playground 12.73% <ø> (ø)
tiup 14.60% <ø> (+0.02%) ⬆️
unittest 21.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/task/builder.go 86.44% <100.00%> (-13.56%) ⬇️
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/manager/check.go 0.74% <0.00%> (-68.15%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-57.92%) ⬇️
pkg/cluster/task/copy_file.go 0.00% <0.00%> (-52.94%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-50.97%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-46.67%) ⬇️
components/cluster/command/audit.go 38.46% <0.00%> (-46.15%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410c25c...c8bce36. Read the comment docs.

@srstack srstack changed the title cluster: fixed the bug that the nightly version could not be compared cluster: the nightly version could not be compared Jan 2, 2022
@srstack srstack changed the title cluster: the nightly version could not be compared cluster: nightly version could not be compared Jan 2, 2022
@AstroProfundis
Copy link
Contributor

/hold

wait for verification from reporter

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2022
@AstroProfundis
Copy link
Contributor

/unhold

There is no response from reporter for few days, I'll merge this, if anything still not working we could fix that in another PR.

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c8bce36

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 7, 2022
@ti-chi-bot ti-chi-bot merged commit f7a536b into pingcap:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
4 participants