-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: nightly version could not be compared #1702
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
I'm not sure for the time being whether there is a comparison of nightly versions in other places. |
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
- Coverage 53.12% 48.64% -4.49%
==========================================
Files 303 303
Lines 34245 34261 +16
==========================================
- Hits 18192 16663 -1529
- Misses 13907 15606 +1699
+ Partials 2146 1992 -154
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/hold wait for verification from reporter |
…into fix-nightly-version
/unhold There is no response from reporter for few days, I'll merge this, if anything still not working we could fix that in another PR. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c8bce36
|
What problem does this PR solve?
close pingcap/tiflow#4149
What is changed and how it works?
Get the complete nightly version number before initconfig operation
Check List
Tests
Code changes
Side effects
Related changes
Release notes: