Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: scale-out topology cannot inherit the global configuration #1701

Merged
merged 7 commits into from
Jan 4, 2022

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Dec 30, 2021

What problem does this PR solve?

close #1697

What is changed and how it works?

scale-out topology cannot inherit the global configuration

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has interface methods change

Side effects

  • Increased code complexity

Related changes

  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2021
@srstack srstack self-assigned this Dec 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #1701 (7d1b477) into master (45c5017) will decrease coverage by 0.02%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1701      +/-   ##
==========================================
- Coverage   53.24%   53.22%   -0.02%     
==========================================
  Files         303      303              
  Lines       34189    34199      +10     
==========================================
- Hits        18201    18200       -1     
- Misses      13854    13862       +8     
- Partials     2134     2137       +3     
Flag Coverage Δ
cluster 41.47% <53.85%> (-0.01%) ⬇️
dm 24.73% <53.85%> (+0.01%) ⬆️
playground 12.75% <0.00%> (-0.01%) ⬇️
tiup 14.61% <0.00%> (-0.03%) ⬇️
unittest 21.35% <61.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/check.go 68.89% <0.00%> (ø)
pkg/cluster/spec/parse_topology.go 79.41% <72.73%> (-1.02%) ⬇️
pkg/cluster/manager/scale_out.go 42.21% <100.00%> (ø)
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️
pkg/cluster/spec/tiflash.go 68.51% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c5017...7d1b477. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.8.2 milestone Dec 30, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7d1b477

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2022
@ti-chi-bot ti-chi-bot merged commit 99bbe1d into pingcap:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster: scale-out topology cannot inherit the global configuration
4 participants