Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: add dm hosts to node_exporter list #1654

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1653

What is changed and how it works?

Add hosts of DM nodes to the host list so that prometheus config will be rendered with them as node_exporter targets.

@AstroProfundis AstroProfundis self-assigned this Dec 6, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #1654 (ee2a39f) into master (c1bd929) will increase coverage by 27.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1654       +/-   ##
===========================================
+ Coverage   15.55%   42.71%   +27.15%     
===========================================
  Files         151      232       +81     
  Lines       15273    21823     +6550     
===========================================
+ Hits         2376     9321     +6945     
+ Misses      12380    11065     -1315     
- Partials      517     1437      +920     
Flag Coverage Δ
cluster 42.71% <0.00%> (?)
integrate 42.71% <0.00%> (+27.15%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/monitoring.go 60.33% <0.00%> (+60.33%) ⬆️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/repository/progress.go 23.07% <0.00%> (-76.93%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-67.40%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/repository/v1manifest/keys.go 5.33% <0.00%> (-58.67%) ⬇️
pkg/repository/merge_mirror.go 0.00% <0.00%> (-58.51%) ⬇️
... and 216 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1bd929...ee2a39f. Read the comment docs.

@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ee2a39f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2021
@ti-chi-bot ti-chi-bot merged commit 77f54c2 into pingcap:master Dec 6, 2021
@AstroProfundis AstroProfundis deleted the issue-1653 branch December 6, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't monitor DM-Worker status
4 participants