-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: add dm hosts to node_exporter list #1654
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
5e3afeb
to
ee2a39f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
===========================================
+ Coverage 15.55% 42.71% +27.15%
===========================================
Files 151 232 +81
Lines 15273 21823 +6550
===========================================
+ Hits 2376 9321 +6945
+ Misses 12380 11065 -1315
- Partials 517 1437 +920
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ee2a39f
|
What problem does this PR solve?
Fix #1653
What is changed and how it works?
Add hosts of DM nodes to the host list so that prometheus config will be rendered with them as
node_exporter
targets.