cluster: fix can't skip confirmation of scale-out

[srstack]

What problem does this PR solve?

close #1640

What is changed and how it works?

fix can't skip confirmation of scale-out

Check List

Tests

• Manual test (add detailed scripts or steps below)

 ./tiup-cluster scale-out cluster-name scale-out.yaml --yes

 ./tiup-cluster scale-out cluster-name scale-out.yaml --stage1 --yes
 ./tiup-cluster scale-out cluster-name scale-out.yaml --stage2 --yes

Code changes

• Has exported variable/fields change

Side effects

Related changes

Release notes:

NONE

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov-commenter]

Codecov Report

Merging #1645 (930a426) into master (c6b2e51) will increase coverage by 34.83%.
The diff coverage is 15.38%.

@@             Coverage Diff             @@
##           master    #1645       +/-   ##
===========================================
+ Coverage   15.58%   50.41%   +34.83%     
===========================================
  Files         151      294      +143     
  Lines       15250    26981    +11731     
===========================================
+ Hits         2376    13603    +11227     
+ Misses      12357    11310     -1047     
- Partials      517     2068     +1551     

Flag	Coverage Δ
cluster	43.82% <15.38%> (?)
dm	25.87% <15.38%> (?)
integrate	50.41% <15.38%> (+34.83%)	⬆️
playground	13.33% <ø> (?)
tiup	15.58% <ø> (ø)
unittest	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cluster/manager/scale_out.go	36.05% <15.38%> (ø)
components/cluster/command/reload.go	80.64% <0.00%> (ø)
pkg/cluster/manager/manager.go	77.41% <0.00%> (ø)
pkg/cluster/task/sysctl.go	68.42% <0.00%> (ø)
components/cluster/command/enable.go	75.00% <0.00%> (ø)
components/dm/command/destroy.go	63.15% <0.00%> (ø)
pkg/cluster/task/update_meta.go	85.00% <0.00%> (ø)
pkg/cluster/ansible/service.go	0.00% <0.00%> (ø)
pkg/cluster/task/copy_file.go	57.14% <0.00%> (ø)
... and 237 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b2e51...930a426. Read the comment docs.

[onlyacat]

I guess it might be more user-friendly to print the warning while skipping the confirmation? So that the users know what happens during the procedure.

[srstack]

I guess it might be more user-friendly to print the warning while skipping the confirmation? So that the users know what happens during the procedure.

yes~ I am going to fix it

[AstroProfundis]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 930a426