-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: add additional prom scrape_configs #1641
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
===========================================
+ Coverage 15.57% 34.43% +18.85%
===========================================
Files 151 232 +81
Lines 15254 21821 +6567
===========================================
+ Hits 2376 7513 +5137
- Misses 12361 13173 +812
- Partials 517 1135 +618
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I don't think the nested multi-line config is a good idea. We had been using nested multi-line format for the There are many editors trying to automatically prepending indents when you edit the file, that's sweet in most cases, but not working well when there is anything nested and will be used to another file with different structure. -- edit Oh I see it's not a nested multi-line config string, but rather a |
6e41226
to
aca90fb
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1b21c48
|
What problem does this PR solve?
What is changed and how it works?
user may use like this:
Check List
Tests
Code changes
Side effects
Related changes
Release notes: