-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix wrong keys detecting host arch #1610
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8fdff78
|
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
- Coverage 15.71% 13.47% -2.24%
==========================================
Files 149 154 +5
Lines 15097 15651 +554
==========================================
- Hits 2372 2109 -263
- Misses 12208 13140 +932
+ Partials 517 402 -115
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
Introduced in #1423
While
172.31.47.79
is the console machine itself and has multiple instances defined on it in the topology.What is changed and how it works?
When detecting host arch, empty value should not be added to the host set before checking of the value of its
arch
field.Check List
Tests
Related changes
Release notes: