-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --external-url for alertmanager #1608
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
===========================================
+ Coverage 15.71% 40.40% +24.69%
===========================================
Files 149 258 +109
Lines 15096 23073 +7977
===========================================
+ Hits 2372 9323 +6951
- Misses 12207 12391 +184
- Partials 517 1359 +842
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribute!
It would be better to add a ListenAddress for it, so that AlertManager could support VPC environment that listen IP and public access IP are different. (#1537)
But that's not necessarily a demand for this PR, I'd merge this, but it's also welcomed if you'd like to improve more on this.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ec6ab84
|
@reAsOn2010: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
tiup deployed alertmanager creating alerts with unspecified external-url
What is changed and how it works?
the template generating alertmanager config
Check List
Tests
Code changes
Side effects
Related changes
Release notes: