Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --external-url for alertmanager #1608

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

reAsOn2010
Copy link
Contributor

What problem does this PR solve?

tiup deployed alertmanager creating alerts with unspecified external-url

What is changed and how it works?

the template generating alertmanager config

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 2, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from lonng and nexustar November 2, 2021 03:32
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #1608 (4ad54b7) into master (ebbeca0) will increase coverage by 24.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1608       +/-   ##
===========================================
+ Coverage   15.71%   40.40%   +24.69%     
===========================================
  Files         149      258      +109     
  Lines       15096    23073     +7977     
===========================================
+ Hits         2372     9323     +6951     
- Misses      12207    12391      +184     
- Partials      517     1359      +842     
Flag Coverage Δ
cluster 39.35% <ø> (?)
dm 19.72% <ø> (?)
integrate 40.40% <ø> (+24.69%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/repository/progress.go 23.07% <0.00%> (-76.93%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-67.40%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/repository/v1manifest/keys.go 5.33% <0.00%> (-58.67%) ⬇️
pkg/repository/merge_mirror.go 0.00% <0.00%> (-58.51%) ⬇️
pkg/utils/args.go 0.00% <0.00%> (-50.00%) ⬇️
... and 244 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbeca0...4ad54b7. Read the comment docs.

Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribute!

It would be better to add a ListenAddress for it, so that AlertManager could support VPC environment that listen IP and public access IP are different. (#1537)

But that's not necessarily a demand for this PR, I'd merge this, but it's also welcomed if you'd like to improve more on this.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec6ab84

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2021
@ti-chi-bot
Copy link
Member

@reAsOn2010: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AstroProfundis AstroProfundis added this to the v1.7.0 milestone Nov 2, 2021
@AstroProfundis AstroProfundis added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Nov 2, 2021
@ti-chi-bot ti-chi-bot merged commit 440fe98 into pingcap:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants