Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cannot get component manifest #1581

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

playground fail to run when first install (without manifest file

What is changed and how it works?

get from server when no local manifest

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #1581 (b5f9766) into master (ce4f204) will increase coverage by 29.01%.
The diff coverage is 87.50%.

❗ Current head b5f9766 differs from pull request most recent head 19c8674. Consider uploading reports for the commit 19c8674 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1581       +/-   ##
===========================================
+ Coverage   15.77%   44.78%   +29.01%     
===========================================
  Files         149      247       +98     
  Lines       15023    23297     +8274     
===========================================
+ Hits         2370    10434     +8064     
+ Misses      12134    11265      -869     
- Partials      519     1598     +1079     
Flag Coverage Δ
cluster 43.05% <0.00%> (?)
integrate 44.78% <87.50%> (+29.01%) ⬆️
playground 13.53% <87.50%> (?)
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/v1_repository.go 45.86% <87.50%> (+2.75%) ⬆️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/repository/v1manifest/keys.go 5.33% <0.00%> (-58.67%) ⬇️
pkg/repository/merge_mirror.go 0.00% <0.00%> (-58.51%) ⬇️
pkg/utils/args.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/repository/store/txn.go 0.00% <0.00%> (-49.67%) ⬇️
... and 229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4f204...19c8674. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 19c8674

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
@ti-chi-bot ti-chi-bot merged commit 5c91cf9 into pingcap:master Oct 13, 2021
@AstroProfundis AstroProfundis added this to the v1.6.1 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants