-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(component/bench): report wrong latency for tpcc workload #1577
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
+ Coverage 26.17% 26.18% +0.01%
==========================================
Files 266 266
Lines 24063 24063
==========================================
+ Hits 6299 6302 +3
+ Misses 16941 16939 -2
+ Partials 823 822 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
605fe52
to
8101db8
Compare
Signed-off-by: lob <[email protected]>
Signed-off-by: lob <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 77d781a
|
What problem does this PR solve?
tiup-bench
What is changed and how it works?
Update corresponding code to match
go-tpc v1.0.7
. The bug was caused by version & default parameter mismatch.New
go-tpc
also introduced ch-benchmark workload.Check List
Tests
Run tpcc workload as the issue did.
Code changes
Related changes
Release notes: