Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component/bench): report wrong latency for tpcc workload #1577

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

lobshunter
Copy link
Contributor

@lobshunter lobshunter commented Oct 12, 2021

What problem does this PR solve?

What is changed and how it works?

Update corresponding code to match go-tpc v1.0.7. The bug was caused by version & default parameter mismatch.
New go-tpc also introduced ch-benchmark workload.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Run tpcc workload as the issue did.

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Related changes

  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #1577 (77d781a) into master (bd92867) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
+ Coverage   26.17%   26.18%   +0.01%     
==========================================
  Files         266      266              
  Lines       24063    24063              
==========================================
+ Hits         6299     6302       +3     
+ Misses      16941    16939       -2     
+ Partials      823      822       -1     
Flag Coverage Δ
integrate 15.81% <ø> (+0.01%) ⬆️
tiup 15.81% <ø> (+0.01%) ⬆️
unittest 22.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/store/txn.go 63.75% <0.00%> (+2.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd92867...77d781a. Read the comment docs.

@lobshunter lobshunter force-pushed the fix-bench branch 2 times, most recently from 605fe52 to 8101db8 Compare October 12, 2021 05:16
components/bench/main.go Outdated Show resolved Hide resolved
@AstroProfundis AstroProfundis added this to the v1.6.1 milestone Oct 12, 2021
@AstroProfundis AstroProfundis added the component/bench Issues about the tiup-bench component label Oct 12, 2021
Signed-off-by: lob <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 77d781a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2021
@ti-chi-bot ti-chi-bot merged commit 7a10615 into pingcap:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/bench Issues about the tiup-bench component size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup bench report wrong latency for tpcc workload
6 participants