Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that lost numa_node when generating PD config #1565

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

onlyacat
Copy link
Contributor

What problem does this PR solve?

Fixes #1563

What is changed and how it works?

invoke function WithNumaNode while generating PD config file

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2021
@AstroProfundis AstroProfundis added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2021

Codecov Report

Merging #1565 (2115f5a) into master (55581f2) will increase coverage by 12.06%.
The diff coverage is 0.00%.

❗ Current head 2115f5a differs from pull request most recent head 6405c97. Consider uploading reports for the commit 6405c97 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1565       +/-   ##
===========================================
+ Coverage   26.20%   38.27%   +12.06%     
===========================================
  Files         266      291       +25     
  Lines       24037    26212     +2175     
===========================================
+ Hits         6300    10032     +3732     
+ Misses      16915    14790     -2125     
- Partials      822     1390      +568     
Flag Coverage Δ
dm 19.85% <0.00%> (?)
integrate 28.66% <0.00%> (+12.84%) ⬆️
playground 13.54% <0.00%> (?)
tiup 15.81% <0.00%> (-0.01%) ⬇️
unittest 22.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/pd.go 18.03% <0.00%> (-0.10%) ⬇️
pkg/cluster/operation/action.go 39.61% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 28.57% <0.00%> (ø)
components/dm/task/update_dm_meta.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
pkg/cluster/operation/destroy.go 27.43% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 24.13% <0.00%> (ø)
components/playground/instance/tidb.go 84.61% <0.00%> (ø)
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55581f2...6405c97. Read the comment docs.

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6405c97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2021
@ti-chi-bot ti-chi-bot merged commit 7ad8f97 into pingcap:master Sep 26, 2021
@AstroProfundis AstroProfundis added this to the v1.5.7 milestone Sep 26, 2021
@onlyacat onlyacat deleted the my-tiup branch September 29, 2021 07:56
@AstroProfundis AstroProfundis modified the milestones: v1.5.7, v1.6.0 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiup lost numa_node for pd when generating run_pd.sh
6 participants