Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tiup] add remove dir when fail to install #1562

Merged
merged 3 commits into from
Sep 26, 2021

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

fix #1555

What is changed and how it works?

add os.RemoveAll when fail to install component

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #1562 (5ac29e3) into master (9813159) will increase coverage by 8.13%.
The diff coverage is 0.00%.

❗ Current head 5ac29e3 differs from pull request most recent head 6263410. Consider uploading reports for the commit 6263410 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
+ Coverage   26.22%   34.36%   +8.13%     
==========================================
  Files         266      242      -24     
  Lines       24034    22577    -1457     
==========================================
+ Hits         6303     7758    +1455     
+ Misses      16910    13521    -3389     
- Partials      821     1298     +477     
Flag Coverage Δ
cluster 28.75% <0.00%> (?)
integrate 34.36% <0.00%> (+18.52%) ⬆️
tiup 15.81% <0.00%> (-0.03%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/v1_repository.go 51.18% <0.00%> (-9.22%) ⬇️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/semver.go 7.08% <0.00%> (-79.53%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-77.78%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-75.76%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-71.43%) ⬇️
pkg/utils/error.go 0.00% <0.00%> (-61.54%) ⬇️
pkg/cluster/executor/local.go 0.00% <0.00%> (-56.95%) ⬇️
pkg/cluster/audit/audit.go 11.57% <0.00%> (-56.85%) ⬇️
pkg/cluster/ansible/inventory.go 0.00% <0.00%> (-55.88%) ⬇️
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9813159...6263410. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8c15b10

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2021
@ti-chi-bot
Copy link
Member

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AstroProfundis AstroProfundis added this to the v1.5.7 milestone Sep 26, 2021
@ti-chi-bot ti-chi-bot merged commit 55581f2 into pingcap:master Sep 26, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.5.7, v1.6.0 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup needs to determine whether the executable file exists
4 participants