-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix panic when cant openDB on tiup-bench #1557
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1557 +/- ##
=======================================
Coverage 26.24% 26.24%
=======================================
Files 266 266
Lines 24001 24001
=======================================
Hits 6298 6298
Misses 16883 16883
Partials 820 820
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5662d19
|
What problem does this PR solve?
when cannot connect to DB, tiup-bench panic . fix #1548
What is changed and how it works?
instead of panic, just exit(1) and warning
Check List
Tests
Code changes
Side effects
Related changes
Release notes: