Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic when cant openDB on tiup-bench #1557

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

when cannot connect to DB, tiup-bench panic . fix #1548

What is changed and how it works?

instead of panic, just exit(1) and warning

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #1557 (5662d19) into master (2e089a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1557   +/-   ##
=======================================
  Coverage   26.24%   26.24%           
=======================================
  Files         266      266           
  Lines       24001    24001           
=======================================
  Hits         6298     6298           
  Misses      16883    16883           
  Partials      820      820           
Flag Coverage Δ
integrate 15.81% <ø> (ø)
tiup 15.81% <ø> (ø)
unittest 22.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e089a2...5662d19. Read the comment docs.

@nexustar nexustar closed this Sep 18, 2021
@nexustar nexustar reopened this Sep 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2021
@AstroProfundis AstroProfundis added the component/bench Issues about the tiup-bench component label Sep 18, 2021
@AstroProfundis AstroProfundis added this to the v1.5.7 milestone Sep 18, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5662d19

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2021
@ti-chi-bot ti-chi-bot merged commit 20455db into pingcap:master Sep 18, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.5.7, v1.6.0 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/bench Issues about the tiup-bench component size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup bench tpch panic when it fails to access tidb
4 participants