-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support start playground offline when specify version #1553
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1553 +/- ##
===========================================
+ Coverage 26.30% 56.36% +30.06%
===========================================
Files 266 291 +25
Lines 24012 26187 +2175
===========================================
+ Hits 6316 14760 +8444
+ Misses 16879 9401 -7478
- Partials 817 2026 +1209
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e431efe
|
What problem does this PR solve?
tiup playground
cant run offlineWhat is changed and how it works?
do'nt download manifest files from Internet when specify version
Check List
Tests
Code changes
Side effects
Related changes
Release notes: