Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support start playground offline when specify version #1553

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Sep 6, 2021

What problem does this PR solve?

tiup playground cant run offline

What is changed and how it works?

do'nt download manifest files from Internet when specify version

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from 9547 and lucklove September 6, 2021 10:50
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #1553 (e431efe) into master (b718fb0) will increase coverage by 30.06%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1553       +/-   ##
===========================================
+ Coverage   26.30%   56.36%   +30.06%     
===========================================
  Files         266      291       +25     
  Lines       24012    26187     +2175     
===========================================
+ Hits         6316    14760     +8444     
+ Misses      16879     9401     -7478     
- Partials      817     2026     +1209     
Flag Coverage Δ
cluster 43.93% <0.00%> (?)
dm 26.18% <0.00%> (?)
integrate 50.93% <57.14%> (+34.82%) ⬆️
playground 13.80% <61.53%> (?)
tiup 16.08% <57.14%> (-0.03%) ⬇️
unittest 22.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/list.go 41.37% <25.00%> (-0.47%) ⬇️
pkg/repository/v1_repository.go 61.18% <76.92%> (+1.34%) ⬆️
pkg/repository/v1manifest/types.go 81.15% <0.00%> (-2.90%) ⬇️
pkg/repository/v1manifest/local_manifests.go 40.00% <0.00%> (-1.06%) ⬇️
components/playground/instance/tiflash.go 61.98% <0.00%> (ø)
pkg/logger/audit.go 57.89% <0.00%> (ø)
components/playground/instance/tidb.go 84.61% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 78.57% <0.00%> (ø)
pkg/cluster/operation/destroy.go 59.88% <0.00%> (ø)
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b718fb0...e431efe. Read the comment docs.

Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e431efe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2021
@ti-chi-bot ti-chi-bot merged commit 0284d62 into pingcap:master Sep 7, 2021
nexustar added a commit to nexustar/tiup that referenced this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants