-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix binpath not work #1545
fix binpath not work #1545
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1545 +/- ##
==========================================
+ Coverage 26.32% 29.71% +3.38%
==========================================
Files 267 248 -19
Lines 24098 23809 -289
==========================================
+ Hits 6345 7074 +729
+ Misses 16934 15591 -1343
- Partials 819 1144 +325
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkg/exec/run.go
Outdated
binPath, err = env.BinaryPath(p.Component, selectVer) | ||
if err != nil { | ||
return nil, err | ||
} | ||
} | ||
installPath, _ := filepath.Split(binPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better use filepath.Dir()
for this usage.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c622219
|
What problem does this PR solve?
when binpath is provided, tiup still download unesserary component, fix #1534
What is changed and how it works?
don't download when binpath is provided,and fix a parameter
Check List
Tests
Code changes
Side effects
Related changes
Release notes: