Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: update os check #1535

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1450

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis self-assigned this Aug 27, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #1535 (4d75d5a) into master (3241005) will increase coverage by 29.90%.
The diff coverage is 0.00%.

❗ Current head 4d75d5a differs from pull request most recent head 413e3e1. Consider uploading reports for the commit 413e3e1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1535       +/-   ##
===========================================
+ Coverage   26.28%   56.18%   +29.90%     
===========================================
  Files         267      292       +25     
  Lines       24069    26239     +2170     
===========================================
+ Hits         6326    14743     +8417     
+ Misses      16922     9477     -7445     
- Partials      821     2019     +1198     
Flag Coverage Δ
cluster 43.95% <0.00%> (?)
dm 26.31% <0.00%> (?)
integrate 50.76% <0.00%> (+34.65%) ⬆️
playground 13.84% <ø> (?)
tiup 16.08% <ø> (-0.02%) ⬇️
unittest 22.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 48.58% <0.00%> (ø)
pkg/repository/store/txn.go 61.74% <0.00%> (-2.02%) ⬇️
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/dm/task/update_dm_meta.go 86.04% <0.00%> (ø)
pkg/logger/debug.go 20.00% <0.00%> (ø)
components/playground/instance/pd.go 75.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
components/playground/instance/tiflash.go 61.98% <0.00%> (ø)
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3241005...413e3e1. Read the comment docs.

@ti-chi-bot
Copy link
Member

@nexustar: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

@nexustar: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AstroProfundis AstroProfundis merged commit 090b201 into pingcap:master Aug 30, 2021
@AstroProfundis AstroProfundis deleted the os-check branch August 30, 2021 03:29
AstroProfundis added a commit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkOSInfo is not given the correct advise for CentOS 8
4 participants