Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ComponentManifests simultaneously when tiup list #1532

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

tiup list takes too long time

What is changed and how it works?

update ComponentManifests simultaneously when tiup list

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from lonng and lucklove August 23, 2021 08:15
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #1532 (2b62cfe) into master (74b96e0) will increase coverage by 8.27%.
The diff coverage is 75.00%.

❗ Current head 2b62cfe differs from pull request most recent head 947d6e9. Consider uploading reports for the commit 947d6e9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
+ Coverage   26.24%   34.51%   +8.27%     
==========================================
  Files         267      280      +13     
  Lines       24064    25744    +1680     
==========================================
+ Hits         6316     8886    +2570     
+ Misses      16925    15635    -1290     
- Partials      823     1223     +400     
Flag Coverage Δ
dm 19.70% <0.00%> (?)
integrate 25.80% <75.00%> (+9.76%) ⬆️
tiup 16.07% <75.00%> (+0.03%) ⬆️
unittest 22.83% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/v1_repository.go 62.06% <75.00%> (+1.72%) ⬆️
pkg/logger/logger.go 100.00% <0.00%> (ø)
pkg/cluster/operation/action.go 39.61% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 28.57% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 24.13% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/cluster/operation/destroy.go 27.76% <0.00%> (ø)
pkg/logger/audit.go 57.89% <0.00%> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b96e0...947d6e9. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@nexustar: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 947d6e9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@nexustar nexustar merged commit 15d5997 into pingcap:master Aug 23, 2021
@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Aug 23, 2021
@nexustar nexustar deleted the reduce-network branch August 23, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants