-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some desc when execute tiup-cluster restart
#1523
Conversation
Add a warning description when the cluster restarts Help understand the impact of restart,
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1523 +/- ##
===========================================
+ Coverage 26.24% 38.19% +11.94%
===========================================
Files 267 292 +25
Lines 24064 26234 +2170
===========================================
+ Hits 6316 10020 +3704
+ Misses 16925 14822 -2103
- Partials 823 1392 +569
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
It seems there are some issues with the image Github Actions uses, I'll wait until tomorrow to see if it could be fixed, otherwise we may need to update our CI jobs to use another image. |
Do i need to do something |
Nope, I believe it's an issue on Github side, I'll try to find a way to workaround that. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 669b0af
|
Add a warning description when the cluster restarts
Help understand the impact of restart,
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: