Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some desc when execute tiup-cluster restart #1523

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented Aug 18, 2021

Add a warning description when the cluster restarts
Help understand the impact of restart,

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • Has persistent data change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

Add a warning description when the cluster restarts
Help understand the impact of restart,
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #1523 (be48071) into master (228012c) will increase coverage by 11.94%.
The diff coverage is 0.00%.

❗ Current head be48071 differs from pull request most recent head 669b0af. Consider uploading reports for the commit 669b0af to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1523       +/-   ##
===========================================
+ Coverage   26.24%   38.19%   +11.94%     
===========================================
  Files         267      292       +25     
  Lines       24064    26234     +2170     
===========================================
+ Hits         6316    10020     +3704     
+ Misses      16925    14822     -2103     
- Partials      823     1392      +569     
Flag Coverage Δ
dm 19.71% <0.00%> (?)
integrate 28.52% <0.00%> (+12.47%) ⬆️
playground 13.84% <ø> (?)
tiup 16.04% <ø> (ø)
unittest 22.81% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/basic.go 11.01% <0.00%> (+11.01%) ⬆️
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 28.57% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/logger/debug.go 20.00% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
pkg/cluster/operation/destroy.go 27.76% <0.00%> (ø)
components/playground/instance/tiflash.go 61.98% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 83.33% <0.00%> (ø)
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228012c...669b0af. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2021
@AstroProfundis AstroProfundis added this to the v1.5.6 milestone Aug 19, 2021
@AstroProfundis
Copy link
Contributor

It seems there are some issues with the image Github Actions uses, I'll wait until tomorrow to see if it could be fixed, otherwise we may need to update our CI jobs to use another image.

@glkappe
Copy link
Contributor Author

glkappe commented Aug 20, 2021

Do i need to do something

@AstroProfundis
Copy link
Contributor

Nope, I believe it's an issue on Github side, I'll try to find a way to workaround that.

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 669b0af

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@ti-chi-bot ti-chi-bot merged commit 74b96e0 into pingcap:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants