-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: fix bug which can't specify db port #1511
playground: fix bug which can't specify db port #1511
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
"testing" | ||
|
||
"github.com/BurntSushi/toml" | ||
"github.com/pingcap/tidb/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are avoiding dependency upon tidb
and other components by intend, please use general interface objects (map[string]interface{}
with type assertion) to decode the config.
Or simply provide a command line argument in playground
to specify TiDB port and overwrite the default.
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
===========================================
+ Coverage 26.26% 56.17% +29.90%
===========================================
Files 267 292 +25
Lines 24047 26222 +2175
===========================================
+ Hits 6316 14730 +8414
+ Misses 16908 9470 -7438
- Partials 823 2022 +1199
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f32e266
|
What problem does this PR solve?
The command "tiup playground" can't specify db port even though customizing --db.config
What is changed and how it works?
When db port is specified, it will be passed by parameter -P in function of "NewTiDBInstance"
Check List
Tests
Code changes
NONE
Side effects
NONE
Related changes
Release notes: