-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: Set terminal title #1506
Conversation
This sets the terminal title to "TiUP Playground: <name>" where name is the last part of the datadir. With `tiup -T foobar playground` etc. this name can be set. Also `tiup client` uses the same names.
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
This needs to be tested with a few terminal emulators on macOS and Linux for compatibility issues. |
Codecov Report
@@ Coverage Diff @@
## master #1506 +/- ##
==========================================
+ Coverage 26.26% 30.72% +4.45%
==========================================
Files 267 279 +12
Lines 23834 24420 +586
==========================================
+ Hits 6261 7503 +1242
+ Misses 16750 15920 -830
- Partials 823 997 +174
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 587633d
|
What problem does this PR solve?
This sets the terminal title to "TiUP Playground: " where name
is the last part of the datadir. With
tiup -T foobar playground
etc.this name can be set. Also
tiup client
uses the same names.Check List
Tests
Release notes: