-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update embed examples #1502
Update embed examples #1502
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
===========================================
+ Coverage 26.17% 56.12% +29.95%
===========================================
Files 267 292 +25
Lines 23939 26074 +2135
===========================================
+ Hits 6265 14634 +8369
+ Misses 16850 9431 -7419
- Partials 824 2009 +1185
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1ad3357
|
What problem does this PR solve?
Deploying monitor agents in
tiup-dm
is supported in a slightly different way as intiup-cluster
, but it was not documented anywhere. This causes issues like #1501What is changed and how it works?
Add example of specifying monitor agent configs in the full topology example of
tiup-dm
, which can be printed withtiup-dm template --full
. The section is commented as the default behavior is not to deploy those agents to avoid conflict with tidb clusters deployed bytiup-cluster
.Also adjusted the directory layout of
embed
, move examples to a dedicated path.Check List
Tests
Release notes: