Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update topology.example.yaml #1484

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

ichn-hu
Copy link
Contributor

@ichn-hu ichn-hu commented Jul 12, 2021

What problem does this PR solve?

the original link is 404

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • N/A

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from nrc July 12, 2021 08:50
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2021
@CLAassistant
Copy link

CLAassistant commented Jul 12, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2021
@AstroProfundis
Copy link
Contributor

@ichn-hu Thank you for the contribution, please sign the CLA so that we can merge your PR.

@ichn-hu
Copy link
Contributor Author

ichn-hu commented Jul 13, 2021

@ichn-hu Thank you for the contribution, please sign the CLA so that we can merge your PR.

signed

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9fbad2d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2021
@ti-chi-bot ti-chi-bot merged commit 7031e03 into pingcap:master Jul 13, 2021
@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants