-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manifest errors in list component should not be returned, change to warning #1466
Conversation
to warning Reason: 1. If the manifest is already available locally, the local component should be listed, but output warning 2. If there is no local manifest, in case of update manifest error, init manifest will also fail and will not continue
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
===========================================
+ Coverage 24.85% 53.20% +28.35%
===========================================
Files 267 292 +25
Lines 21267 23161 +1894
===========================================
+ Hits 5285 12323 +7038
+ Misses 15175 8906 -6269
- Partials 807 1932 +1125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@c4pt0r Please sign the CLA |
/merge |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9168548
|
…ge (#1466) to warning Reason: 1. If the manifest is already available locally, the local component should be listed, but output warning 2. If there is no local manifest, in case of update manifest error, init manifest will also fail and will not continue
Update manifest errors in
list
command should not be returned, change to warningReason:
If the manifest is already available locally, the local component
should be listed, but output warning
If there is no local manifest, in case of update manifest error,
init manifest will also fail and will not continue
#1465