Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest errors in list component should not be returned, change to warning #1466

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

c4pt0r
Copy link
Member

@c4pt0r c4pt0r commented Jul 1, 2021

Update manifest errors in list command should not be returned, change to warning

Reason:

  1. If the manifest is already available locally, the local component
    should be listed, but output warning

  2. If there is no local manifest, in case of update manifest error,
    init manifest will also fail and will not continue

#1465

to warning

Reason:
1. If the manifest is already available locally, the local component
   should be listed, but output warning

2. If there is no local manifest, in case of update manifest error,
   init manifest will also fail and will not continue
@AstroProfundis AstroProfundis added the component/tiup Issues about the TiUP package management component itself label Jul 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #1466 (983e644) into master (a293227) will increase coverage by 28.35%.
The diff coverage is 0.00%.

❗ Current head 983e644 differs from pull request most recent head 9168548. Consider uploading reports for the commit 9168548 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1466       +/-   ##
===========================================
+ Coverage   24.85%   53.20%   +28.35%     
===========================================
  Files         267      292       +25     
  Lines       21267    23161     +1894     
===========================================
+ Hits         5285    12323     +7038     
+ Misses      15175     8906     -6269     
- Partials      807     1932     +1125     
Flag Coverage Δ
cluster 40.04% <ø> (?)
dm 24.85% <ø> (?)
integrate 47.81% <0.00%> (+32.57%) ⬆️
playground 13.41% <ø> (?)
tiup 15.24% <0.00%> (ø)
unittest 21.49% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/list.go 40.94% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 57.05% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 81.81% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
pkg/cluster/operation/systemd.go 70.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 78.26% <0.00%> (ø)
... and 210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a293227...9168548. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2021

CLA assistant check
All committers have signed the CLA.

@AstroProfundis
Copy link
Contributor

@c4pt0r Please sign the CLA

@AstroProfundis
Copy link
Contributor

/merge

@AstroProfundis AstroProfundis added this to the v1.5.3 milestone Jul 1, 2021
@ti-chi-bot ti-chi-bot requested review from lonng and lucklove July 1, 2021 10:48
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 1, 2021
@AstroProfundis
Copy link
Contributor

/merge

@AstroProfundis AstroProfundis merged commit 45e4471 into pingcap:master Jul 1, 2021
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9168548

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2021
AstroProfundis pushed a commit that referenced this pull request Jul 15, 2021
…ge (#1466)

to warning

Reason:
1. If the manifest is already available locally, the local component
   should be listed, but output warning

2. If there is no local manifest, in case of update manifest error,
   init manifest will also fail and will not continue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tiup Issues about the TiUP package management component itself size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants