Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: use SHELL from environment for completion #1455

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jun 25, 2021

What problem does this PR solve?

tiup completion doesn't auto-detect the shell based on $SHELL and doesn't accept /bin/bash as a value.

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Run tiup completion bash and tiup completion

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #1455 (83f936b) into master (0edbf77) will increase coverage by 20.39%.
The diff coverage is 0.00%.

❗ Current head 83f936b differs from pull request most recent head e784286. Consider uploading reports for the commit e784286 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1455       +/-   ##
===========================================
+ Coverage   24.66%   45.05%   +20.39%     
===========================================
  Files         267      280       +13     
  Lines       21368    22841     +1473     
===========================================
+ Hits         5270    10292     +5022     
+ Misses      15292    10897     -4395     
- Partials      806     1652      +846     
Flag Coverage Δ
cluster 32.07% <ø> (?)
dm 24.74% <ø> (?)
integrate 41.35% <0.00%> (+26.23%) ⬆️
tiup 15.14% <0.00%> (+0.02%) ⬆️
unittest 21.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/completion.go 19.84% <0.00%> (-0.31%) ⬇️
pkg/cluster/operation/scale_in.go 50.00% <0.00%> (ø)
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 69.56% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 23.63% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
components/dm/task/update_dm_meta.go 85.29% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
pkg/cluster/operation/action.go 62.02% <0.00%> (ø)
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edbf77...e784286. Read the comment docs.

@dveeden dveeden force-pushed the shell_completion branch from 71679e0 to fb4fa0e Compare June 25, 2021 13:01
@AstroProfundis AstroProfundis added this to the v1.5.3 milestone Jun 29, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@AstroProfundis: /merge in this pull request requires 1 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e784286

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2021
@ti-chi-bot ti-chi-bot merged commit 4b4dcd5 into pingcap:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants