-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: use SHELL from environment for completion #1455
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1455 +/- ##
===========================================
+ Coverage 24.66% 45.05% +20.39%
===========================================
Files 267 280 +13
Lines 21368 22841 +1473
===========================================
+ Hits 5270 10292 +5022
+ Misses 15292 10897 -4395
- Partials 806 1652 +846
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
71679e0
to
fb4fa0e
Compare
/merge |
@AstroProfundis: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e784286
|
What problem does this PR solve?
tiup completion
doesn't auto-detect the shell based on$SHELL
and doesn't accept/bin/bash
as a value.What is changed and how it works?
Check List
Tests
Run
tiup completion bash
andtiup completion
Release notes: